[
https://issues.apache.org/jira/browse/YARN-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904876#comment-13904876
]
Xuan Gong commented on YARN-1666:
---------------------------------
bq. LocalConfigurationProvider: Use the bootstrapConf for looking into
class-path. Creating configs is not inexpensive!
Changed.
bq. In refreshNodes(), you need to create yarn-conf as new
YarnConfiguration(false)
Similarly in refreshSuperUserGroupsConfiguration() and all the other refresh
methods. You said "It is fine. Because we will load related configuration later
by using addResource(Configuration) which will reload and overwrite all the
properties.". That is not true if we are not overwriting all properties. We
need to start on a clean slate.
Make sense, but we can not do new YarnConfiguration(false). I am using new
Configuration(false) for all the cases
bq. HostsFileReader: Switch the includes and excludes sets only after both are
successfully read?
fixed
> Make admin refreshNodes work across RM failover
> -----------------------------------------------
>
> Key: YARN-1666
> URL: https://issues.apache.org/jira/browse/YARN-1666
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-1666.1.patch, YARN-1666.2.patch, YARN-1666.2.patch,
> YARN-1666.3.patch, YARN-1666.4.patch, YARN-1666.4.patch, YARN-1666.5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
