[
https://issues.apache.org/jira/browse/YARN-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912394#comment-13912394
]
Jian He commented on YARN-1713:
-------------------------------
Some comments on patch apache-yarn-1713.cumulative.patch:
- styling issue, please follow the convention of 80 column limit
- appIdToRMApp is not actually adding Id to RMApp, more likely
getRMAppFromRMContext() ?
- we have created factory method in each user-facing record for instantiating
the record, e.g.: ApplicationSubmissionContext.newInstance, you can use that.
{code}
createAppSubmissionContext(AppSubmissionInfo newApp) t
{code}
- createNewApplication should be a get request as it only returns the
applicationId etc. just like the one in ClientRMService.getNewApplicaiton
- you can attach a name for the XmlRootElement like @XmlRootElement(name =
"appAttempt") to specify the element name, so we can do @XmlRootElement(name =
“newApplication”)
- Note that RMWebServices.hasAcess() is checked against VIEW_APP permission, in
the case of submit/kill, we should check against MODIFY_APP
> Implement getnewapplication and submitapp as part of RM web service
> -------------------------------------------------------------------
>
> Key: YARN-1713
> URL: https://issues.apache.org/jira/browse/YARN-1713
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: apache-yarn-1713.cumulative.patch, apache-yarn-1713.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
