[
https://issues.apache.org/jira/browse/YARN-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913187#comment-13913187
]
Varun Vasudev commented on YARN-1713:
-------------------------------------
> styling issue, please follow the convention of 80 column limit
Fixed the styling issue
> appIdToRMApp is not actually adding Id to RMApp, more likely
> getRMAppFromRMContext() ?
Yes. Renamed to getRMAppForAppId
> we have created factory method in each user-facing record for instantiating
> the record, e.g.: ApplicationSubmissionContext.newInstance, you can use that.
Fixed
> createNewApplication should be a get request as it only returns the
> applicationId etc. just like the one in ClientRMService.getNewApplication
I'm not sure about this. According to REST principles, GET is supposed to
idempotent. Is getNewApplication idempotent?
> you can attach a name for the XmlRootElement like @XmlRootElement(name =
> "appAttempt") to specify the element name, so we can do @XmlRootElement(name
> = “newApplication”)
Fixed
> Note that RMWebServices.hasAcess() is checked against VIEW_APP permission, in
> the case of submit/kill, we should check against MODIFY_APP
Fixed
> Implement getnewapplication and submitapp as part of RM web service
> -------------------------------------------------------------------
>
> Key: YARN-1713
> URL: https://issues.apache.org/jira/browse/YARN-1713
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: apache-yarn-1713.3.patch,
> apache-yarn-1713.cumulative.2.patch, apache-yarn-1713.cumulative.patch,
> apache-yarn-1713.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
