[ 
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916618#comment-13916618
 ] 

Zhijie Shen commented on YARN-1389:
-----------------------------------

Some high level comments for the initial patch:

1. ApplicationClientProtocol and ApplicationHistoryProtocol are able to share a 
base interface now?

2. Javadoc in ApplicationHistoryProtocol says the data is obtained from AHS, 
which is not correct.

3. YarnClientImpl misses the implementation for getting 
attempts/container/containers

4. Users are not able to get completed application list via YarnClient

5. Like RMApp, make createApplicationAttemptReport/ContainerReport as part of 
RMAppAttempt/RMContainer.

> ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog 
> APIs
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-1389
>                 URL: https://issues.apache.org/jira/browse/YARN-1389
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1389-1.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the 
> reports of *finished* application attempts and containers, we should do the 
> same for ApplicationClientProtocol, which will return the reports of 
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance 
> to ApplicationClientProtocol, while that of finished instance to 
> ApplicationHistoryProtocol, making it transparent to the users.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to