[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919170#comment-13919170
]
Mayank Bansal commented on YARN-1389:
-------------------------------------
Thanks [~zjshen] for the review
bq. 1. ApplicationClientProtocol and ApplicationHistoryProtocol are able to
share a base interface now?
I think we decided we will keep the interfaces seprate.
bq. 2. Javadoc in ApplicationHistoryProtocol says the data is obtained from
AHS, which is not correct.
Done
bq. 3. YarnClientImpl misses the implementation for getting
attempts/container/containers
Done
bq. 4. Users are not able to get completed application list via YarnClient
Done
bq. 5. Like RMApp, make createApplicationAttemptReport/ContainerReport as part
of RMAppAttempt/RMContainer.
These are just utility functions, do you think they are needed in RMAPPATtempt
and RMContainer?
Updating the latest patch.
Thanks,
Mayank
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog
> APIs
> ----------------------------------------------------------------------------------
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
