[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920402#comment-13920402
]
Karthik Kambatla commented on YARN-1525:
----------------------------------------
Comments on the latest patch (it would be easier to refer to patches if they
are versioned):
# RMHAUtils#findActiveRMId: looks like we return before resetting the id to
initial RM-id? It might be safer to just create a copy of the conf - new
YarnConfiguration(yarnConf), so we don't have to store the initial value and
reset at the end.
{code}
if (haState.equals(HAServiceState.ACTIVE)) {
yarnConf.set(YarnConfiguration.RM_HA_ID, rmId);
return currentId;
}
} catch (Exception e) {
}
}
yarnConf.set(YarnConfiguration.RM_HA_ID, rmId);
{code}
# RMDispatcher: remove TODO
{code}
RMDispatcher(WebApp webApp, Injector injector, Router router) {
super(webApp, injector, router);
// TODO Auto-generated constructor stub
}
{code}
# Don't see much use for RMWebApp#standbyMode. Why not just use isStandbyMode().
# Nit: Spurious commit. Get rid of it?
{code}
- void setRedirectPath(String path) { this.redirectPath = path; }
+ protected void setRedirectPath(String path) {
+ this.redirectPath = path;
+ }
{code}
> Web UI should redirect to active RM when HA is enabled.
> -------------------------------------------------------
>
> Key: YARN-1525
> URL: https://issues.apache.org/jira/browse/YARN-1525
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Cindy Li
> Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
> YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
> YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
> Yarn1525.secure.patch, Yarn1525.secure.patch
>
>
> When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
