[ 
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923039#comment-13923039
 ] 

Karthik Kambatla commented on YARN-1525:
----------------------------------------

bq. In the case the standby RM, where isStandbyMode() returns true and we start 
to buildRedirectPath, switches to be active, keeping the variable 
RMWebApp#standbyMode allows the behavior to be consistent from the time we 
tested isStandbyMode() first in RMDispatcher.service().
I see. This can be a little confusing. Can we change {{boolean isStandbyMode}} 
to {{void checkStandbyMode}} and set the field standbyMode. We can then may be 
access this field directly or through an accessor.

bq.  I've been using a temporary configuration (which you can find from 
RMWebApp.getRedirectPath()). I was actually resetting RMid back in the original 
code. It was necessary if I was not using a temporary configuration. But I'll 
remove them since I've been using temporary configuration.
Now I see why it was working fine. Still, I think we should also fix 
RMHAUtils#findActiveRMHAId to use a copy and not mutate the conf that is passed 
to it, as this is a util method and will likely be used at other places. 

We should also get rid of getting and setting rm-id in 
RMWebApp#buildRedirectPath.

> Web UI should redirect to active RM when HA is enabled.
> -------------------------------------------------------
>
>                 Key: YARN-1525
>                 URL: https://issues.apache.org/jira/browse/YARN-1525
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Cindy Li
>         Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, 
> YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, 
> YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, 
> Yarn1525.secure.patch, Yarn1525.secure.patch
>
>
> When failover happens, web UI should redirect to the current active rm.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to