[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923278#comment-13923278
]
Mayank Bansal commented on YARN-1389:
-------------------------------------
Thanks [~zjshen] for review
bq. 1. In javadoc of ApplicationClientProtocol, we shouldn't mention
ApplicationHistoryServer, because the applications obtained from this protocol
are all from RM cache instead of history store
Done
bq. 2. attempts won't be null, and getApplications doesn't throw
ApplicationNotFoundException when getting an empty list of applications. Let's
keep the behavior consistent. Same for getContainers. And in YarnClientImpl,
don't process ApplicationAttemptNotFoundException and
ContainerNotFoundException in the corresponding places.
In some cases in can be null so keeping it that way. We wanted to avoid get
status for application.
bq. 3. TestClientRMService needs more test cases as well, like what you did in
TestYarnClient
Done
bq. 4. Please test the new APIs in a presudo cluster to verify whether it works
or not. Thanks!
Done , it works :)
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -------------------------------------------------------------------------------------
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
