[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931076#comment-13931076
]
Mayank Bansal commented on YARN-1389:
-------------------------------------
Thanks [~zjshen] for the review
bq. 1. is it simpler to use "e instanceof XXXXNotFoundException"?
Not needed , essentially same
bq. getFinishedStatus() is not necessary. You can directly do when() on
getDiagnostics/getExitStatus/getState.
Done
bq. 3. There're a lot of code duplication in TestClientRMService. You can move
the common code into a private createClientRMService method, which is called by
your test methods.
Done
bq. 4. Shouldn't we remove "throw new YarnException("History service is not
enabled.");" in YarnClientImpl?
Actually we should have this if history is not enabled
bq. 5. Shouldn't we assert fail here, because the exception is not excepted?
Similar in other test cases.
Done
bq. I've tested the patch locally. "yarn applicationattempt" seems to be able
to get and list attempts of RM cached application. "yarn container" is going to
result in the following crash:
Fixed
bq. One more nit: please add some comments to say "we're going to fix the issue
of showing non-running containers of the running application in YARN-1794" in
getContainers/getContainerReport of ClientRMService.
Done
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -------------------------------------------------------------------------------------
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
