[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931483#comment-13931483
]
Mayank Bansal commented on YARN-1389:
-------------------------------------
Thanks [~zjshen] for review
bq. 1. Please remove this comment
Done
bq. 2. We'd better not, otherwise, when AHS is disabled, if the object is not
found in RM, we will get this annoying exception. Please follow YOUR previous
code pattern in YarnClientImpl#getApplicationReport
Done
bq. 3. Shouldn't you throw ApplicationNotFoundException, as what you did in
getContainerReport()?
we pass attemt id for containers so its better to have AttemptNotFoundEXception.
bq. Please remove this code. attempts will never be null. It can be empty, but
it's reasonable. If this application even hasn't its first attempt, the list is
empty
Done (Changed the check to empty)
bq. 5. Similarly, rmContainers can't be null. After YARN-1794, we should have
some walk-around to get the finished containers from RM.
I think till we fixed this we need to have this check, I may be removing it
part of this JIRA.
bq. 6. Just return null. Let UI to decide is going to be printed if the
diagnostics is not available.
Done
Thanks,
Mayank
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -------------------------------------------------------------------------------------
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
