[
https://issues.apache.org/jira/browse/YARN-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932412#comment-13932412
]
Zhijie Shen commented on YARN-1717:
-----------------------------------
Thanks for the patch, Billie! Here're some more comments:
1. For the newly added configurations, add the corresponding ones in
yarn-default.xml.
2. Should these aging mechanism related configs have a leveldb section in the
config name? Because they're only related to the leveldb impl.
3. Let's don't delete super.serviceInit(conf); Put it at last?
{code}
- super.serviceInit(conf);
+
+ if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_TTL_ENABLE, true)) {
+ deletionThread = new DeletionThread(conf);
+ deletionThread.start();
+ }
{code}
4. Interrupt, and then join the thread. See the other examples in the project.
{code}
+ deletionThread.interrupt();
+ while (deletionThread.isAlive()) {
+ try {
+ LOG.info("Waiting for deletion thread to complete its current " +
+ "action");
+ Thread.sleep(1000);
+ } catch (InterruptedException e) {}
+ }
+ }
{code}
5. It seems not necessary to refactor "getEntity" into two methods, doesn't it?
{code}
@Override
public TimelineEntity getEntity(String entityId, String entityType,
EnumSet<Field> fields) throws IOException {
{code}
{code}
+ private EntityWithReverseRelatedEntities getEntity(String entityId,
+ String entityType, EnumSet<Field> fields, byte[] revStartTime)
+ throws IOException {
{code}
6. There're 4 warnings in the new LevedbTimelineStore.java. Would you please
fix them?
7. In discardOldEntities, if one IOException happens, is it good to move on
with the following discarding operations?
> Enable offline deletion of entries in leveldb timeline store
> ------------------------------------------------------------
>
> Key: YARN-1717
> URL: https://issues.apache.org/jira/browse/YARN-1717
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1717.1.patch, YARN-1717.2.patch, YARN-1717.3.patch,
> YARN-1717.4.patch, YARN-1717.5.patch, YARN-1717.6-extra.patch,
> YARN-1717.6.patch, YARN-1717.7.patch, YARN-1717.8.patch, YARN-1717.9.patch
>
>
> The leveldb timeline store implementation needs the following:
> * better documentation of its internal structures
> * internal changes to enable deleting entities
> ** never overwrite existing primary filter entries
> ** add hidden reverse pointers to related entities
--
This message was sent by Atlassian JIRA
(v6.2#6252)
