[
https://issues.apache.org/jira/browse/YARN-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934288#comment-13934288
]
Zhijie Shen commented on YARN-1717:
-----------------------------------
Some minor things on the patch:
1. Rename the class to "EntityDiscardThread" or something?
{code}
+ private class DeletionThread extends Thread {
{code}
2. Have a warn level log here?
{code}
+ } catch (InterruptedException ignored) {
+ }
{code}
Another arguable issue is: it is possible that the entity is expired according
to its TS, while part of its events is still in TTL. We do deletion according
to entity's TS and at the entity's granularity, thus, the events that are still
alive are likely to be deleted as well.
> Enable offline deletion of entries in leveldb timeline store
> ------------------------------------------------------------
>
> Key: YARN-1717
> URL: https://issues.apache.org/jira/browse/YARN-1717
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1717.1.patch, YARN-1717.10.patch,
> YARN-1717.2.patch, YARN-1717.3.patch, YARN-1717.4.patch, YARN-1717.5.patch,
> YARN-1717.6-extra.patch, YARN-1717.6.patch, YARN-1717.7.patch,
> YARN-1717.8.patch, YARN-1717.9.patch
>
>
> The leveldb timeline store implementation needs the following:
> * better documentation of its internal structures
> * internal changes to enable deleting entities
> ** never overwrite existing primary filter entries
> ** add hidden reverse pointers to related entities
--
This message was sent by Atlassian JIRA
(v6.2#6252)
