[
https://issues.apache.org/jira/browse/YARN-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938954#comment-13938954
]
Karthik Kambatla commented on YARN-1705:
----------------------------------------
Patch looks mostly good. Minor comments:
# TestRMHA#verifyClusterMetrics need not take QueueMetrics as an argument. The
method itself could fetch the metrics.
# TestRMHA#testStartAndTransitions removes blank lines between cases making the
test hard to read. Can we put them back in?
> Cluster metrics are off after failover
> --------------------------------------
>
> Key: YARN-1705
> URL: https://issues.apache.org/jira/browse/YARN-1705
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.3.0
> Reporter: Karthik Kambatla
> Assignee: Rohith
> Attachments: YARN-1705.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
