[
https://issues.apache.org/jira/browse/YARN-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942631#comment-13942631
]
Karthik Kambatla commented on YARN-1775:
----------------------------------------
bq. closer approximation of RSS = Math.min(sharedDirty, pss) + privateDirty +
privateClean.
Sounds reasonable to me. While enforcing memory constraints, I wonder if people
would want to use any other definitions of RSS to be more conservative or
aggressive. Do you think it would make sense to provide these options
separately, and have what you have as the default? We can punt this to a
different JIRA, just wanted to bring it up.
Whichever we choose to go, we should definitely the way RSS is computed in
yarn-default.xml, so users understand what they are switching to.
bq.
yarn.nodemanager.container-monitor.procfs-based-proces-tree.smaps-based-rss.enabled
That seems awfully long. May be something between what the patch has and
Vinod's suggestion :)
Other than that, adding to Vinod's cosmetic changes list:
# Rename MEM_INFO to MemInfo to go with other enums in the source?
# Also, may be just list the values line-by-line, so we can add comments
corresponding to values, if any.
# We should probably switch the following two ifs?
{code}
if (isSmapEnabled()) {
return getSmapBasedCumulativeRssmem(olderThanAge);
}
if (PAGE_SIZE < 0) {
return 0;
}
{code}
# javadoc error?
{code}
* @param pinfo
* @param procfsDir
*/
private static void constructProcessSMAPInfo(ProcessMemInfo pInfo,
{code}
> Create SMAPBasedProcessTree to get PSS information
> --------------------------------------------------
>
> Key: YARN-1775
> URL: https://issues.apache.org/jira/browse/YARN-1775
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Attachments: YARN-1775-v2.patch, YARN-1775-v3.patch,
> yarn-1775-2.4.0.patch
>
>
> Create SMAPBasedProcessTree (by extending ProcfsBasedProcessTree), which will
> make use of PSS for computing the memory usage.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
