[ 
https://issues.apache.org/jira/browse/YARN-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942581#comment-13942581
 ] 

Colin Patrick McCabe commented on YARN-1775:
--------------------------------------------

Thanks for tackling this.

In {{isSmapEnabled}}, I think it's typical to cache the result of 
{{conf.getBoolean}}.  That avoids doing the hash table lookup all the time.

It seems like the method used here is to exclude shared read-only mappings from 
the total RSS.  It might be nice to explain that in {{yarn-default.xml}}.  
Also, I wonder if we could make this default to true and simply disable it when 
{{/proc/<PID>/smaps}} is not present or writable.

> Create SMAPBasedProcessTree to get PSS information
> --------------------------------------------------
>
>                 Key: YARN-1775
>                 URL: https://issues.apache.org/jira/browse/YARN-1775
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>         Attachments: YARN-1775-v2.patch, YARN-1775-v3.patch, 
> yarn-1775-2.4.0.patch
>
>
> Create SMAPBasedProcessTree (by extending ProcfsBasedProcessTree), which will 
> make use of PSS for computing the memory usage. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to