[ 
https://issues.apache.org/jira/browse/YARN-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996587#comment-13996587
 ] 

Jason Lowe commented on YARN-1751:
----------------------------------

+1, committing this.

> Improve MiniYarnCluster for log aggregation testing
> ---------------------------------------------------
>
>                 Key: YARN-1751
>                 URL: https://issues.apache.org/jira/browse/YARN-1751
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: YARN-1751-trunk.patch, YARN-1751.patch
>
>
> MiniYarnCluster specifies individual remote log aggregation root dir for each 
> NM. Test code that uses MiniYarnCluster won't be able to get the value of log 
> aggregation root dir. The following code isn't necessary in MiniYarnCluster.
>       File remoteLogDir =
>           new File(testWorkDir, MiniYARNCluster.this.getName()
>               + "-remoteLogDir-nm-" + index);
>       remoteLogDir.mkdir();
>       config.set(YarnConfiguration.NM_REMOTE_APP_LOG_DIR,
>           remoteLogDir.getAbsolutePath());
> In LogCLIHelpers.java, dumpAllContainersLogs should pass its conf object to 
> FileContext.getFileContext() call.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to