[ 
https://issues.apache.org/jira/browse/YARN-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995739#comment-13995739
 ] 

Hadoop QA commented on YARN-1751:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12644486/YARN-1751.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3736//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3736//console

This message is automatically generated.

> Improve MiniYarnCluster for log aggregation testing
> ---------------------------------------------------
>
>                 Key: YARN-1751
>                 URL: https://issues.apache.org/jira/browse/YARN-1751
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: YARN-1751-trunk.patch, YARN-1751.patch
>
>
> MiniYarnCluster specifies individual remote log aggregation root dir for each 
> NM. Test code that uses MiniYarnCluster won't be able to get the value of log 
> aggregation root dir. The following code isn't necessary in MiniYarnCluster.
>       File remoteLogDir =
>           new File(testWorkDir, MiniYARNCluster.this.getName()
>               + "-remoteLogDir-nm-" + index);
>       remoteLogDir.mkdir();
>       config.set(YarnConfiguration.NM_REMOTE_APP_LOG_DIR,
>           remoteLogDir.getAbsolutePath());
> In LogCLIHelpers.java, dumpAllContainersLogs should pass its conf object to 
> FileContext.getFileContext() call.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to