Tsuyoshi OZAWA commented on YARN-1474:

Thanks Karthik for the comments. I'd like to make sure one point:

1. In each of the schedulers, I don't think we need the following snippet or 
for that matter the variable initialized at all. reinitialize() would have just 
the contents of else-block.

If we change that {{reinitialize()}} would have just contents of else-black, we 
need to change lots schedulers-related test cases without 
ResourceManager/MockRM to call {{scheduler.init()}} right after 
{{scheduler.setRMContext()}}. Is it acceptable for us?

> Make schedulers services
> ------------------------
>                 Key: YARN-1474
>                 URL: https://issues.apache.org/jira/browse/YARN-1474
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: 2.3.0, 2.4.0
>            Reporter: Sandy Ryza
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-1474.1.patch, YARN-1474.10.patch, 
> YARN-1474.11.patch, YARN-1474.12.patch, YARN-1474.13.patch, 
> YARN-1474.14.patch, YARN-1474.15.patch, YARN-1474.16.patch, 
> YARN-1474.17.patch, YARN-1474.2.patch, YARN-1474.3.patch, YARN-1474.4.patch, 
> YARN-1474.5.patch, YARN-1474.6.patch, YARN-1474.7.patch, YARN-1474.8.patch, 
> YARN-1474.9.patch
> Schedulers currently have a reinitialize but no start and stop.  Fitting them 
> into the YARN service model would make things more coherent.

This message was sent by Atlassian JIRA

Reply via email to