Karthik Kambatla commented on YARN-1474:

Latest patch looks good to me. +1. Given this patch has been under active 
development for a while and no one has refuted the approach, I ll go ahead and 
commit this shortly. 

Thanks [~ozawa] for being patient through the reviews across multiple 
iterations here.

PS: Personally, I would do away with additional methods introduced here in the 
patch - initScheduler and startScheduler. I understand it is a personal 
preference, and I am okay with having these methods.

> Make schedulers services
> ------------------------
>                 Key: YARN-1474
>                 URL: https://issues.apache.org/jira/browse/YARN-1474
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: 2.3.0, 2.4.0
>            Reporter: Sandy Ryza
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-1474.1.patch, YARN-1474.10.patch, 
> YARN-1474.11.patch, YARN-1474.12.patch, YARN-1474.13.patch, 
> YARN-1474.14.patch, YARN-1474.15.patch, YARN-1474.16.patch, 
> YARN-1474.17.patch, YARN-1474.18.patch, YARN-1474.19.patch, 
> YARN-1474.2.patch, YARN-1474.3.patch, YARN-1474.4.patch, YARN-1474.5.patch, 
> YARN-1474.6.patch, YARN-1474.7.patch, YARN-1474.8.patch, YARN-1474.9.patch
> Schedulers currently have a reinitialize but no start and stop.  Fitting them 
> into the YARN service model would make things more coherent.

This message was sent by Atlassian JIRA

Reply via email to