[ https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015986#comment-14015986 ]
Tsuyoshi OZAWA commented on YARN-2122: -------------------------------------- Thank you for taking this JIRA, [~rkanter]. I think your patch fixes the issue itself. I have one comment - how about overriding serviceInit()/serviceStart()/serviceStop() instead of init()/start()/stop()? Should we do this on another JIRA? [~kkambatl], what do you think? > In AllocationFileLoaderService, the reloadThread should be created in init() > and started in start() > --------------------------------------------------------------------------------------------------- > > Key: YARN-2122 > URL: https://issues.apache.org/jira/browse/YARN-2122 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Affects Versions: 2.4.0 > Reporter: Karthik Kambatla > Assignee: Robert Kanter > Attachments: YARN-2122.patch > > > AllcoationFileLoaderService has this reloadThread that is currently created > and started in start(). Instead, it should be created in init() and started > in start(). -- This message was sent by Atlassian JIRA (v6.2#6252)