Tsuyoshi OZAWA commented on YARN-2052:

[~vinodkv], thank you for the comment. I agree with fixing toString or other 
parts on another JIRA. 

The attached patch includes following updates:

* Updated yarn_protos.proto to include RM's id(cluster_timestamp and uuid of 
rm-id). RM-Id should be converted into  UUID, because RM-ID can include 
underscore and it can prevent users from parsing correctly.
* Added {{setClusterTimestamp}}/{{setRMUUID}} to {{ContainerId}} and 
implemented them in {{ContainerIdPBImpl}}.
* Updated TestFileSystemApplicationHistoryStore, because of the size of 
entities are changed.

[~jianhe], can you take a look?

Therefore, I think container_XXX_000_uuid_rm1 is better format. 

Note that this was wrong, I meant the format should be 

> ContainerId creation after work preserving restart is broken
> ------------------------------------------------------------
>                 Key: YARN-2052
>                 URL: https://issues.apache.org/jira/browse/YARN-2052
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2052.1.patch
> Container ids are made unique by using the app identifier and appending a 
> monotonically increasing sequence number to it. Since container creation is a 
> high churn activity the RM does not store the sequence number per app. So 
> after restart it does not know what the new sequence number should be for new 
> allocations.

This message was sent by Atlassian JIRA

Reply via email to