Tsuyoshi OZAWA commented on YARN-2130:

[~kkambatl], thank you for the review. Updated a patch to address the comments:
1. Made RMAppManager's and ResourceTrackerService's constructor minimal.
2. Changed to leave the fields in ClientRMService.
3. Fixed to pass tests including initialization order of mocks and pointing 
correct objects from mocks. TestClientRMService#mockResourceScheduler is one of 

> Cleanup: Adding getRMAppManager, getQueueACLsManager, 
> getApplicationACLsManager to RMContext
> --------------------------------------------------------------------------------------------
>                 Key: YARN-2130
>                 URL: https://issues.apache.org/jira/browse/YARN-2130
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2130.1.patch, YARN-2130.2.patch, YARN-2130.3.patch, 
> YARN-2130.4.patch, YARN-2130.5.patch

This message was sent by Atlassian JIRA

Reply via email to