Sunil G commented on YARN-2143:

Hi [~gp.leftnoteasy]

*FairScheduler#warnOrKillContainer* and *CapacityScheduler#killContainer* 
mainly has only one common part. Both will invoke its own completedContainer 
with KILL event.
After doing more code review, I feel that we may not be able to merge these two 
methods as a single one in AbstractYarnScheduler. But this new api in 
AbstractYarnScheduler can be invoked from both these methods 
(warnOrKillContainer and killContainer) to perform adding ResourceRequest back 
to Scheduler purpose.

If this is fine, may be we can use this JIRA only to add a new method named 
*killPreemptedContainer* for AbstractYarnScheduler and this will be called from 
warnOrKillContainer and killContainer. Please share your thoughts 
[~leftnoteasy] and [~vinodkv]

> Merge common killContainer logic of Fair/Capacity scheduler into 
> AbstractYarnScheduler
> --------------------------------------------------------------------------------------
>                 Key: YARN-2143
>                 URL: https://issues.apache.org/jira/browse/YARN-2143
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
> Currently, CapacityScheduler has killContainer API inherited from 
> PreemptableResourceScheduler, and FairScheduler uses warnOrKillContainer to 
> do container preemption. We'd better to merge common code to kill container 
> into AbstractYarnScheduler.

This message was sent by Atlassian JIRA

Reply via email to