Wangda Tan commented on YARN-2143:

Hi Sunil,
Thanks for your comment, I took a look at FairScheduler/CapacityScheduler 
again, I think completedContainer looks more like what we need put in 
AbstractYarnScheduler. Both of warnOrKillContainer and killContainer invokes 
This issue is created because of YARN-1408, I feel we'd better leave this alone 
here and wait for some feedbacks from community, we can add ResourceRequest 
logic separately in Fair/CapacityScheduler for now, and refactor it in the 

> Merge common killContainer logic of Fair/Capacity scheduler into 
> AbstractYarnScheduler
> --------------------------------------------------------------------------------------
>                 Key: YARN-2143
>                 URL: https://issues.apache.org/jira/browse/YARN-2143
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
> Currently, CapacityScheduler has killContainer API inherited from 
> PreemptableResourceScheduler, and FairScheduler uses warnOrKillContainer to 
> do container preemption. We'd better to merge common code to kill container 
> into AbstractYarnScheduler.

This message was sent by Atlassian JIRA

Reply via email to