[
https://issues.apache.org/jira/browse/YARN-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055958#comment-14055958
]
Wangda Tan commented on YARN-2069:
----------------------------------
And
bq. 4. No more check will happen with preemptFrom logic as resToObtain is 0.
{code}
+ if (Resources.lessThan(rc, clusterResource, userLimitforQueue,
+ userConsumedResource)) {
+ // As we have used more resources the user limit,
+ // we need to claim back the resources equivalent to
+ // consumed resources by user - user limit
+ Resource resourcesToClaimBackFromUser = Resources.subtract(
+ userConsumedResource, userLimitforQueue);
{code}
I think we need add a check here,
resourcesToClaimBackFromUser=min(resourcesToClaimBackFromUser, resToObtain),
is it? [~mayank_bansal]
> CS queue level preemption should respect user-limits
> ----------------------------------------------------
>
> Key: YARN-2069
> URL: https://issues.apache.org/jira/browse/YARN-2069
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Mayank Bansal
> Attachments: YARN-2069-trunk-1.patch, YARN-2069-trunk-2.patch,
> YARN-2069-trunk-3.patch, YARN-2069-trunk-4.patch
>
>
> This is different from (even if related to, and likely share code with)
> YARN-2113.
> YARN-2113 focuses on making sure that even if queue has its guaranteed
> capacity, it's individual users are treated in-line with their limits
> irrespective of when they join in.
> This JIRA is about respecting user-limits while preempting containers to
> balance queue capacities.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
