[
https://issues.apache.org/jira/browse/YARN-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057787#comment-14057787
]
Jian He commented on YARN-2208:
-------------------------------
looks good overall,
1. Maybe change passwords to use concurrentHashMap and use read/write lock
guard nextMasterKey/currentMasterKey for better concurrency as this is a chatty
class.
2. Put In the same line
{code}
+ "ms and AMRMTokenKeyActivationDelay: " + this.activationDelay
+ "ms");
}
else if (identifier.getKeyId() == this.currentMasterKey.getMasterKey()
{code}
3. Info level for easier debugging, while stabilizing this feature.
{code}
if (LOG.isDebugEnabled()) {
LOG.debug("Activating next master key with id: "
+ this.nextMasterKey.getMasterKey().getKeyId());
}
{code}
4. createAndGetAMRMToken, add info log here also.
> AMRMTokenManager need to have a way to roll over AMRMToken
> ----------------------------------------------------------
>
> Key: YARN-2208
> URL: https://issues.apache.org/jira/browse/YARN-2208
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-2208.1.patch, YARN-2208.2.patch, YARN-2208.3.patch,
> YARN-2208.4.patch, YARN-2208.5.patch, YARN-2208.5.patch, YARN-2208.6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
