Xuan Gong commented on YARN-2208:

bq. This is a micro-optimization. Let's get rid of caching the passwords - that 
way we are consistent with other token-handling in the system.


Also, I comment out those from 
    // TODO: fix this on YARN-2211
//    Token<AMRMTokenIdentifier> amrmToken = loadedAttempt1.getAMRMToken();
//    Assert.assertArrayEquals(amrmToken.getPassword(),
//      rm2.getRMContext().getAMRMTokenSecretManager().retrievePassword(
//        amrmToken.decodeIdentifier()));

We will fix this on YARN-2211. At that ticket, we will store the currentMaster 
key and nextMaster key. When RM restart happens, we can re-produce the password 
based on the stored currentMaster key and nextMaster key.

But, in this ticket, since we do not cache password anymore (we only cache the 
appAttemptId), and we do not have any logic to save the currentMaster key and 
nextMaster key. So, those lines are expected to fail. To make a clean build, I 
would like to comment them out, and put them back when we work on YARN-2211.

> AMRMTokenManager need to have a way to roll over AMRMToken
> ----------------------------------------------------------
>                 Key: YARN-2208
>                 URL: https://issues.apache.org/jira/browse/YARN-2208
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2208.1.patch, YARN-2208.2.patch, YARN-2208.3.patch, 
> YARN-2208.4.patch, YARN-2208.5.patch, YARN-2208.5.patch, YARN-2208.6.patch, 
> YARN-2208.7.patch, YARN-2208.8.patch

This message was sent by Atlassian JIRA

Reply via email to