[ 
https://issues.apache.org/jira/browse/YARN-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062573#comment-14062573
 ] 

Jian He commented on YARN-2211:
-------------------------------

some comments:
- setCurrnetMasterKeyData, setNextMasterKeyData methods not used 
- change not needed?
{code}
 |----- AMRMTOKEN_SECRET_MANAGER_ROOT_ZNODE_NAME
{code}
- Fix “System.out.println(stateData.getCurrentTokenMasterKey());” in 
FileSystemRMStateStore 
- Test: add test in restart scenario that AM issued with rolled-over AMRMToken 
is still able to communicate with restarted RM. 
testAppAttemptTokensRestoredOnRMRestart may help writing the test.

> RMStateStore needs to save AMRMToken master key for recovery when RM 
> restart/failover happens 
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-2211
>                 URL: https://issues.apache.org/jira/browse/YARN-2211
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2211.1.patch, YARN-2211.2.patch, YARN-2211.3.patch
>
>
> After YARN-2208, AMRMToken can be rolled over periodically. We need to save 
> related Master Keys and use them to recover the AMRMToken when RM 
> restart/failover happens



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to