[ 
https://issues.apache.org/jira/browse/YARN-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067553#comment-14067553
 ] 

Hadoop QA commented on YARN-2323:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12656727/YARN-2323.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
                  
org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
                  
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4372//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4372//console

This message is automatically generated.

> FairShareComparator creates too much Resource object
> ----------------------------------------------------
>
>                 Key: YARN-2323
>                 URL: https://issues.apache.org/jira/browse/YARN-2323
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Hong Zhiguo
>            Assignee: Hong Zhiguo
>            Priority: Minor
>         Attachments: YARN-2323.patch
>
>
> Each call of {{FairShareComparator}} creates a new Resource object "one":
> {code}
> Resource one = Resources.createResource(1);
> {code}
> At the volume of 1000 nodes and 1000 apps, the comparator will be called more 
> than 10 million times per second, thus creating more than 10 million object 
> "one", which is unnecessary.
> Since the object "one" is read-only and is never referenced outside of 
> comparator, we could make it static.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to