[
https://issues.apache.org/jira/browse/YARN-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067744#comment-14067744
]
Wei Yan commented on YARN-2323:
-------------------------------
Good catch, [~zhiguohong]. Thanks, LGTM.
> FairShareComparator creates too much Resource object
> ----------------------------------------------------
>
> Key: YARN-2323
> URL: https://issues.apache.org/jira/browse/YARN-2323
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Reporter: Hong Zhiguo
> Assignee: Hong Zhiguo
> Priority: Minor
> Attachments: YARN-2323.patch
>
>
> Each call of {{FairShareComparator}} creates a new Resource object "one":
> {code}
> Resource one = Resources.createResource(1);
> {code}
> At the volume of 1000 nodes and 1000 apps, the comparator will be called more
> than 10 million times per second, thus creating more than 10 million object
> "one", which is unnecessary.
> Since the object "one" is read-only and is never referenced outside of
> comparator, we could make it static.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
