[
https://issues.apache.org/jira/browse/YARN-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074198#comment-14074198
]
Zhijie Shen commented on YARN-2347:
-----------------------------------
[~djp], it's a good idea to refactor the code to make the common classes. The
changes are straightfoward, and look good to me almost. Just some minor
comments.
1. Mark the class \@Prviate and \@Unstable?
{code}
+public class StateVersionPBImpl extends StateVersion {
{code}
2. I'm not sure StateVersion is the best name in this case. For example,
StateVersion for a db schema sounds weird to me. Why not YarnVersion or even
Version?
> Consolidate RMStateVersion and NMDBSchemaVersion into StateVersion in
> yarn-server-common
> ----------------------------------------------------------------------------------------
>
> Key: YARN-2347
> URL: https://issues.apache.org/jira/browse/YARN-2347
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: YARN-2347-v2.patch, YARN-2347-v3.patch, YARN-2347.patch
>
>
> We have similar things for version state for RM, NM, TS (TimelineServer),
> etc. I think we should consolidate them into a common object.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
