[ https://issues.apache.org/jira/browse/YARN-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075518#comment-14075518 ]
Junping Du commented on YARN-2347: ---------------------------------- Thanks for review and comments, [~zjshen]! Nice catch for javadoc issue, will fix it soon. For naming of this generic version, I don't have strong preference on which is better. YarnVersion seems to be a little misleading as we already had "yarn version" command line to list the version of YARN. Version sounds too generic and easily get duplicated (we had a writable object with the same name in Common). Actually, this version get used for RMState, NMState, ShuffleHandler's State, etc. In this case, may not sounds so weird to you? > Consolidate RMStateVersion and NMDBSchemaVersion into StateVersion in > yarn-server-common > ---------------------------------------------------------------------------------------- > > Key: YARN-2347 > URL: https://issues.apache.org/jira/browse/YARN-2347 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Junping Du > Assignee: Junping Du > Attachments: YARN-2347-v2.patch, YARN-2347-v3.patch, YARN-2347.patch > > > We have similar things for version state for RM, NM, TS (TimelineServer), > etc. I think we should consolidate them into a common object. -- This message was sent by Atlassian JIRA (v6.2#6252)