[ 
https://issues.apache.org/jira/browse/YARN-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080598#comment-14080598
 ] 

Xuan Gong commented on YARN-2212:
---------------------------------

bq. AMS#registerApplicationMaster changes not needed.

make changes on authorizeRequest() to let it return AMRMTokenIdentifier instead 
of RMAppAttemptId. So, all the changes in AMS#registerApplicationMaster are for 
this.

bq. May not say stable now.
{code}
  @Stable
  public abstract Token getAMRMToken();
{code}

DONE

bq. ApplicationReport#getAMRMToken for unmanaged AM needs to be updated as well.

When AMRMToken is rolled up, we will update the AMRMToken for current attempt. 
So, ApplicationReport#getAMRMToken will update

bq. we can move the AMRMToken creation from RMAppAttemptImpl to AMLauncher?
 
DONE

bq. Use newInstance instead. 

DONE

bq. Test AMRMClient automatically takes care of the new AMRMToken transfer.

ADDED

bq. Please run on real cluster also and set roll-over interval to a small value 
to make sure it actually works.

tested.

> ApplicationMaster needs to find a way to update the AMRMToken periodically
> --------------------------------------------------------------------------
>
>                 Key: YARN-2212
>                 URL: https://issues.apache.org/jira/browse/YARN-2212
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2212.1.patch, YARN-2212.2.patch, 
> YARN-2212.3.1.patch, YARN-2212.3.patch, YARN-2212.4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to