[ 
https://issues.apache.org/jira/browse/YARN-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082987#comment-14082987
 ] 

Jian He commented on YARN-2212:
-------------------------------

- I meant change the stability of new API instead of ApplicationReport
- Previous constructor already set this ?
{code}
    if (token.getService() != null) {
      amrmToken.setService(new Text(token.getService()));
    }
{code} 
- A lot of duplicated code is copied from TestAMRMClient.java, I think we can 
just put the tests there.
- please remove unnecessary testing code
{code}
      //setting an instance NMTokenCache
      amClient.setNMTokenCache(new NMTokenCache());
      //asserting we are not using the singleton instance cache
      Assert.assertNotSame(NMTokenCache.getSingleton(),
          amClient.getNMTokenCache());
{code}
- Please try on secure cluster too.
- test case: test the token is indeed invalided after it expired
{code}
    // can do allocate call with new AMRMToken
    am.allocate(Records.newRecord(AllocateRequest.class));
{code}

> ApplicationMaster needs to find a way to update the AMRMToken periodically
> --------------------------------------------------------------------------
>
>                 Key: YARN-2212
>                 URL: https://issues.apache.org/jira/browse/YARN-2212
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2212.1.patch, YARN-2212.2.patch, 
> YARN-2212.3.1.patch, YARN-2212.3.patch, YARN-2212.4.patch, YARN-2212.5.patch, 
> YARN-2212.5.patch, YARN-2212.5.rebase.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to