[
https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080750#comment-14080750
]
Hadoop QA commented on YARN-2051:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655677/YARN-2051.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4495//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4495//console
This message is automatically generated.
> Fix code bug and add more unit tests for PBImpls
> ------------------------------------------------
>
> Key: YARN-2051
> URL: https://issues.apache.org/jira/browse/YARN-2051
> Project: Hadoop YARN
> Issue Type: Test
> Reporter: Junping Du
> Assignee: Binglin Chang
> Priority: Critical
> Attachments: YARN-2051.v1.patch
>
>
> From YARN-2016, we can see some bug could exist in PB implementation of
> protocol. The bad news is most of these PBImpl don't have any unit test to
> verify the info is not lost or changed after serialization/deserialization.
> We should add more tests for it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
