Zhijie Shen commented on YARN-2288:

bq. If objects in store will get lost after TS restart, we don't need it. What 
do you think?

I neglect the fact of being persisted. I agree on it.

bq. Do we have plan to persistent MemoryTimelineStore?

At least we're going to have a HbaseTimelineStore. CURRENT_VERSION_INFO can is 
case-by-case for each impl, but TS_STORE_VERSION_KEY is going to be a common 
constant across different impls. In addition,  TS_STORE_VERSION_KEY -> 

some other nits:

1. T -> t?
+          "Incompatible version for Timeline store: expecting version " 

2. Unnecessary change?
-  @SuppressWarnings("resource")

Other than that, I think the patch is good to go.

> Data persistent in timelinestore should be versioned
> ----------------------------------------------------
>                 Key: YARN-2288
>                 URL: https://issues.apache.org/jira/browse/YARN-2288
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: 2.4.1
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-2288-v2.patch, YARN-2288.patch
> We have LevelDB-backed TimelineStore, it should have schema version for 
> changes in schema in future.

This message was sent by Atlassian JIRA

Reply via email to