[
https://issues.apache.org/jira/browse/YARN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111015#comment-14111015
]
Junping Du commented on YARN-2033:
----------------------------------
[~zjshen], the patch looks good to me in over all. I don't have much more
comments, except below. Would you fix it?
bq. First of all, two queries are not duplicate: one to read the application
entity, and the other to read the app attempt entity, and we previously
distinguish ApplicationNotFoundException and
ApplicationAttemptNotFoundException. It is always possible that App1 exists in
the store with the only attempt AppAttempt1 while the user looks up for
AppAttempt2. In this case, we know App1 is there, but AppAttempt2 isn't, so we
will throw ApplicationAttemptNotFoundException.
If we really want to differ the two exceptions, we still can check
ApplicationAttempt first and check Application later (to see if throw
ApplicationNotFoundException instead) if ApplicationAttemptNotFoundException
get thrown there. This is more efficient as we only need to visit DB one time
in most cases. Isn't it?
> Investigate merging generic-history into the Timeline Store
> -----------------------------------------------------------
>
> Key: YARN-2033
> URL: https://issues.apache.org/jira/browse/YARN-2033
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Zhijie Shen
> Attachments: ProposalofStoringYARNMetricsintotheTimelineStore.pdf,
> YARN-2033.1.patch, YARN-2033.2.patch, YARN-2033.3.patch, YARN-2033.4.patch,
> YARN-2033.5.patch, YARN-2033.6.patch, YARN-2033.Prototype.patch,
> YARN-2033_ALL.1.patch, YARN-2033_ALL.2.patch, YARN-2033_ALL.3.patch,
> YARN-2033_ALL.4.patch
>
>
> Having two different stores isn't amicable to generic insights on what's
> happening with applications. This is to investigate porting generic-history
> into the Timeline Store.
> One goal is to try and retain most of the client side interfaces as close to
> what we have today.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
