[
https://issues.apache.org/jira/browse/YARN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126073#comment-14126073
]
Vinod Kumar Vavilapalli commented on YARN-2033:
-----------------------------------------------
Mostly looks fine, this is a rapidly changing part of the code-base! I get a
feeling we need some umbrella cleanup effort to make consistent usage w.r.t
history-service/timeline-service. Anyways, some comments
- RMApplicationHistoryWriter is not really needed anymore. We did document it
to be unstable/alpha too. We can remove it directly instead of deprecating it.
It's a burden to support two interface hierarchies. I'm okay doing it
separately though.
- YarnClientImpl: Calls using AHSClient shouldn't rely on timeline-publisher
yet, we should continue to use APPLICATION_HISTORY_ENABLED for that till we get
rid of AHSClient altogether. We should file a ticket for this too.
- You removed the unstable annotations from ApplicationContext APIs. We should
retain them, this stuff isn't stable yet.
- Rename YarnMetricsPublisher -> {Platform|System}MetricsPublisher to avoid
confusing it with host/daemon metrics that exist outside today?
> Investigate merging generic-history into the Timeline Store
> -----------------------------------------------------------
>
> Key: YARN-2033
> URL: https://issues.apache.org/jira/browse/YARN-2033
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Zhijie Shen
> Attachments: ProposalofStoringYARNMetricsintotheTimelineStore.pdf,
> YARN-2033.1.patch, YARN-2033.2.patch, YARN-2033.3.patch, YARN-2033.4.patch,
> YARN-2033.5.patch, YARN-2033.6.patch, YARN-2033.7.patch,
> YARN-2033.Prototype.patch, YARN-2033_ALL.1.patch, YARN-2033_ALL.2.patch,
> YARN-2033_ALL.3.patch, YARN-2033_ALL.4.patch
>
>
> Having two different stores isn't amicable to generic insights on what's
> happening with applications. This is to investigate porting generic-history
> into the Timeline Store.
> One goal is to try and retain most of the client side interfaces as close to
> what we have today.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
