[
https://issues.apache.org/jira/browse/YARN-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Subramaniam Krishnan updated YARN-2080:
---------------------------------------
Attachment: YARN-2080.patch
Thanks [~vinodkv] for reviewing the patch. I am uploading a new patch that has
includes your feedback:
* Renamed all Yarn config variables as you suggested. I prefer using the
standalone configs as it gives us more flexibility.
* Removed duplicate logging in _ClientRMService_ &
_ReservationInputValidator_. Consistenly uses RMAuditLogger throughout.
* Fixes in AbstractReservationSystem as you suggested.
* Updated stale references to queues in Javadocs of
_YarnClient.submitReservation()_
* _TestYarnClient_ & _TestClientRMService_ use newInstance instead of PBImpls
* Renamed _ReservationRequest.setLeaseDuration()_ was renamed to be simply
_setDuration()_
* Moved _CapacitySchedulerConfiguration_ to YARN-1711
bq. ReservationInputValidator: Deleting a request shouldn't need
validateReservationUpdateRequest->validateReservationDefinition. We only need
the ID validation
That's exactly what's being done. ReservationDefinitions are validated only for
submission/update.
bq. checkReservationACLs: Today anyone who can submit applications can also
submit reservations. We may want to separate them, if you agree, I'll file a
ticket for future separation of these ACLs.
I agree. I have a set of follow up enhancement JIRAs to YARN-1051 in mind one
of which was exactly to consider separation of ACLs as you pointed out.
> Admission Control: Integrate Reservation subsystem with ResourceManager
> -----------------------------------------------------------------------
>
> Key: YARN-2080
> URL: https://issues.apache.org/jira/browse/YARN-2080
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subramaniam Krishnan
> Assignee: Subramaniam Krishnan
> Attachments: YARN-2080.patch, YARN-2080.patch, YARN-2080.patch,
> YARN-2080.patch
>
>
> This JIRA tracks the integration of Reservation subsystem data structures
> introduced in YARN-1709 with the YARN RM. This is essentially end2end wiring
> of YARN-1051.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
