[
https://issues.apache.org/jira/browse/YARN-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129181#comment-14129181
]
Jason Lowe commented on YARN-2056:
----------------------------------
Sorry for coming in late. I think there's an issue with this part of the patch:
{code}
// The per-queue disablePreemption defaults to false (preemption enabled).
// Inherit parent's per-queue disablePreemption value.
boolean parentQueueDisablePreemption = false;
boolean queueDisablePreemption = false;
if (root.getParent() != null) {
String parentQueuePropName = BASE_YARN_RM_PREEMPTION
+ root.getParent().getQueuePath()
+ SUFFIX_DISABLE_PREEMPTION;
parentQueueDisablePreemption =
this.conf.getBoolean(parentQueuePropName, false);
}
String queuePropName = BASE_YARN_RM_PREEMPTION + root.getQueuePath()
+ SUFFIX_DISABLE_PREEMPTION;
queueDisablePreemption =
this.conf.getBoolean(queuePropName, parentQueueDisablePreemption);
{code}
I think it only handles examining the immediate parent for a default value. If
preemption is disabled at a parent two levels or more removed from the leaf
queue then it appears we won't honor that.
> Disable preemption at Queue level
> ---------------------------------
>
> Key: YARN-2056
> URL: https://issues.apache.org/jira/browse/YARN-2056
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.4.0
> Reporter: Mayank Bansal
> Assignee: Eric Payne
> Attachments: YARN-2056.201408202039.txt, YARN-2056.201408260128.txt,
> YARN-2056.201408310117.txt, YARN-2056.201409022208.txt
>
>
> We need to be able to disable preemption at individual queue level
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
