Eric Payne commented on YARN-2056:

[~leftnoteasy], thank you very much for your review comments. I appreciate it.

Regarding the test for "appA running on queueB":
The following assertion tests that appA is preempted, but the preemption 
calculations are done per queue.
+    verify(mDisp, times(10)).handle(argThat(new IsPreemptionRequestFor(appA)));
So, I added the following assertion to make the visual connection between appA 
and queueB:
+    assertTrue("appA should be running on queueB",
+        mCS.getAppsInQueue("queueB").contains(expectedAttemptOnQueueB));
So, the purpose is not really to test that the mockQueue/mockApp worked 
correctly, but to make it obvious that the preemption policy for queueB is 
being exercised. If you think it's not necessary, I will remove it, but I do 
like the link.

> Disable preemption at Queue level
> ---------------------------------
>                 Key: YARN-2056
>                 URL: https://issues.apache.org/jira/browse/YARN-2056
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Mayank Bansal
>            Assignee: Eric Payne
>         Attachments: YARN-2056.201408202039.txt, YARN-2056.201408260128.txt, 
> YARN-2056.201408310117.txt, YARN-2056.201409022208.txt
> We need to be able to disable preemption at individual queue level

This message was sent by Atlassian JIRA

Reply via email to