[ 
https://issues.apache.org/jira/browse/YARN-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137944#comment-14137944
 ] 

Chris Trezzo commented on YARN-2179:
------------------------------------

[~kasha] a couple of comments:

bq. 5. sharedcache-pom: my understand of maven is pretty sparse, so please 
correct me if I am wrong. Looks like sharedcache depends on the RM. If we were 
to embed the sharedcache in the RM, wouldn't that lead to circular dependency? 
How do we plan to solve it?

One approach would be to move the shared cache project back into the RM 
project. This would not affect the ability to run the shared cache manager as a 
separate service, but would be more a code organizational thing. Thoughts?

bq. 6. RemoteAppChecker: Just thinking out loud - in a non-embedded case, what 
happens if we upgrade other daemons/clients but not the SCM and add a new 
completed state? There might not be a solution here though, the worst case 
appears to be that we wouldn't clear the cache when apps end up in that state. 
One alternative is to query the RM for active states or an app being active. I 
am open to adding these APIs (Private for now) to the RM. 

I took a look at the ApplicationReport interface again. Would it make more 
sense to leverage getFinalApplicationStatus() instead of 
getYarnApplicationState()? That way we can just say if the 
FinalApplicationStatus is undefined don't clean it up, otherwise we are safe to 
delete the appId.

I will work on the changes for the other comments and post an updated patch.

> Initial cache manager structure and context
> -------------------------------------------
>
>                 Key: YARN-2179
>                 URL: https://issues.apache.org/jira/browse/YARN-2179
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-2179-trunk-v1.patch, YARN-2179-trunk-v2.patch, 
> YARN-2179-trunk-v3.patch, YARN-2179-trunk-v4.patch, YARN-2179-trunk-v5.patch
>
>
> Implement the initial shared cache manager structure and context. The 
> SCMContext will be used by a number of manager services (i.e. the backing 
> store and the cleaner service). The AppChecker is used to gather the 
> currently running applications on SCM startup (necessary for an scm that is 
> backed by an in-memory store).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to