[
https://issues.apache.org/jira/browse/YARN-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148493#comment-14148493
]
Karthik Kambatla commented on YARN-2179:
----------------------------------------
Comments:
# Nit: YarnConfiguration - The definition of string constants corresponding to
the config names are inconsistently indented. My personal preference is to put
the value being assigned in the subsequent line if it does not all fit in one
line.
# AppChecker constructor that takes a name, should use that name.
# In RemoteAppChecker, I would list all the known ACTIVE_STATES instead of
using the complement:
{code}
private static final EnumSet<YarnApplicationState> ACTIVE_STATES =
EnumSet.complementOf(EnumSet.of(YarnApplicationState.FINISHED,
YarnApplicationState.FAILED,
YarnApplicationState.KILLED));
{code}
# SharedCacheManager: the following two lines should be moved to serviceInit().
We can get rid of serviceStart altogether.
{code}
DefaultMetricsSystem.initialize("SharedCacheManager");
JvmMetrics.initSingleton("SharedCacheManager", null);
{code}
> Initial cache manager structure and context
> -------------------------------------------
>
> Key: YARN-2179
> URL: https://issues.apache.org/jira/browse/YARN-2179
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Attachments: YARN-2179-trunk-v1.patch, YARN-2179-trunk-v2.patch,
> YARN-2179-trunk-v3.patch, YARN-2179-trunk-v4.patch, YARN-2179-trunk-v5.patch,
> YARN-2179-trunk-v6.patch, YARN-2179-trunk-v7.patch
>
>
> Implement the initial shared cache manager structure and context. The
> SCMContext will be used by a number of manager services (i.e. the backing
> store and the cleaner service). The AppChecker is used to gather the
> currently running applications on SCM startup (necessary for an scm that is
> backed by an in-memory store).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
