[ 
https://issues.apache.org/jira/browse/YARN-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141355#comment-14141355
 ] 

Craig Welch commented on YARN-2496:
-----------------------------------

I'm also concerned about this:

Resource maxCapacityConsiderLabel =
        labelManager == null ? clusterResource : labelManager.getQueueResource(
            queueName, labels, clusterResource);

The "labels" are the labels for the queue, but the resource requests coming 
from the application can be a subset of that, no?  So if application "a" is 
running on a queue with lables a and b, but it has a label expression of only 
a, which it is using for resource requests, it's going to get a headroom based 
on nodes with both labels a and b, but in fact it only has a "real" headroom 
for nodes with label "a"

> [YARN-796] Changes for capacity scheduler to support allocate resource 
> respect labels
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2496
>                 URL: https://issues.apache.org/jira/browse/YARN-2496
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2496.patch, YARN-2496.patch, YARN-2496.patch, 
> YARN-2496.patch
>
>
> This JIRA Includes:
> - Add/parse labels option to {{capacity-scheduler.xml}} similar to other 
> options of queue like capacity/maximum-capacity, etc.
> - Include a "default-label-expression" option in queue config, if an app 
> doesn't specify label-expression, "default-label-expression" of queue will be 
> used.
> - Check if labels can be accessed by the queue when submit an app with 
> labels-expression to queue or update ResourceRequest with label-expression
> - Check labels on NM when trying to allocate ResourceRequest on the NM with 
> label-expression
> - Respect  labels when calculate headroom/user-limit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to