[ 
https://issues.apache.org/jira/browse/YARN-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151796#comment-14151796
 ] 

Junping Du commented on YARN-2613:
----------------------------------

Thanks [~jianhe] for the patch. I am reviewing your patch, and some initiative 
comments below. More comments may come later.
{code}
-  public static final int DEFAULT_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS =
+  public static final long DEFAULT_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS =
       15 * 60 * 1000;
+  public static final int DEFAULT_CLIENT_NM_CONNECT_MAX_WAIT_MS =
+      15 * 60 * 1000;
+  public static final long DEFAULT_CLIENT_NM_CONNECT_RETRY_INTERVAL_MS
+      = 10 * 1000;
{code}
I think it is better to keep consistent to use int or long for time intervals 
or wait. IMO, int should be fine enough as it supports up to (2 ^ 31) 
millseconds ~ 50 days.

{code}
-    //TO DO: after HADOOP-9576,  IOException can be changed to EOFException
-    exceptionToPolicyMap.put(IOException.class, retryPolicy);
{code}
Do we have plan to get HADOOP-9576 in? If yes, shall we keep the todo comments 
here?

> NMClient doesn't have retries for supporting rolling-upgrades
> -------------------------------------------------------------
>
>                 Key: YARN-2613
>                 URL: https://issues.apache.org/jira/browse/YARN-2613
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2613.1.patch, YARN-2613.2.patch
>
>
> While NM is rolling upgrade, client should retry NM until it comes up. This 
> jira is to add a NMProxy (similar to RMProxy) with retry implementation to 
> support rolling upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to