[
https://issues.apache.org/jira/browse/YARN-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156905#comment-14156905
]
Karthik Kambatla commented on YARN-2180:
----------------------------------------
Looks mostly good, but for these minor comments:
# App-checker and the store implementations aren't related:
## the app-checker config should be appended to SHARED_CACHE_PREFIX and
IN_MEMORY_STORE
## the variable names should be updated accordingly.
## InMemorySCMStore#createAppCheckerService should move to a util class - how
about changing SharedCacheStructureUtil to SharedCacheUtil and adding this
method there?
# Can we create a follow-up blocker sub-task to revisit all the config names
before we include sharedcache work in a release?
> In-memory backing store for cache manager
> -----------------------------------------
>
> Key: YARN-2180
> URL: https://issues.apache.org/jira/browse/YARN-2180
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Attachments: YARN-2180-trunk-v1.patch, YARN-2180-trunk-v2.patch,
> YARN-2180-trunk-v3.patch, YARN-2180-trunk-v4.patch, YARN-2180-trunk-v5.patch,
> YARN-2180-trunk-v6.patch
>
>
> Implement an in-memory backing store for the cache manager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
