[
https://issues.apache.org/jira/browse/YARN-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142167#comment-14142167
]
Vinod Kumar Vavilapalli commented on YARN-2180:
-----------------------------------------------
The patch looks fine overall, some comments
- yarn.sharedcache.manager.store.impl -> yarn.sharedcache.store or store-class
- YarnConfiguration.SCM_STORE_IMPL -> SCM_STORE/SCM_STORE_CLASS
- We already have Resource, LocalResource. To avoid confuse, shall we use
SharedCacheResource and hence ResourceReference -> SharedCacheResourceReference
and so on everywhere?
- InMemoryStore.bootstrap() can be done as part of serviceInit()
- Synchronization is missing from the InMemoryStore operations? You are using
a ConcurrentHashMap but to insert correctly (multiple apps adding a cache-entry
to the same path) you'll need to use {{putIfAbsent}}? Surprised the test is
presumably passing.
> In-memory backing store for cache manager
> -----------------------------------------
>
> Key: YARN-2180
> URL: https://issues.apache.org/jira/browse/YARN-2180
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Attachments: YARN-2180-trunk-v1.patch, YARN-2180-trunk-v2.patch,
> YARN-2180-trunk-v3.patch
>
>
> Implement an in-memory backing store for the cache manager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
