[ https://issues.apache.org/jira/browse/YARN-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160653#comment-14160653 ]
Jian He commented on YARN-2312: ------------------------------- Patch looks good to me too, thanks Jason for reviewing the patch. bq. Wondering if there should be a utility method on ContainerId to provide this value or if the masking constant should be obtainable from ContainerId. I prefer exposing the constant > Marking ContainerId#getId as deprecated > --------------------------------------- > > Key: YARN-2312 > URL: https://issues.apache.org/jira/browse/YARN-2312 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Attachments: YARN-2312-wip.patch, YARN-2312.1.patch, > YARN-2312.2-2.patch, YARN-2312.2-3.patch, YARN-2312.2.patch, > YARN-2312.4.patch, YARN-2312.5.patch > > > {{ContainerId#getId}} will only return partial value of containerId, only > sequence number of container id without epoch, after YARN-2229. We should > mark {{ContainerId#getId}} as deprecated and use > {{ContainerId#getContainerId}} instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)