[ 
https://issues.apache.org/jira/browse/YARN-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165468#comment-14165468
 ] 

Hadoop QA commented on YARN-2668:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12673938/YARN-2668-001.patch
  against trunk revision db71bb5.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 1 
release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5345//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-YARN-Build/5345//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5345//console

This message is automatically generated.

> yarn-registry JAR won't link against ZK 3.4.5
> ---------------------------------------------
>
>                 Key: YARN-2668
>                 URL: https://issues.apache.org/jira/browse/YARN-2668
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-2668-001.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> It's been reported that the registry code doesn't link against ZK 3.4.5 as 
> the enable/disable SASL client property isn't there, which went in with 
> ZOOKEEPER-1657.
> pulling in the constant and {{isEnabled()}} check will ensure registry 
> linkage, even though the ability for a client to disable SASL auth will be 
> lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to