Rohith commented on YARN-2588:

Thanks Jian He for reviewing patch :-)
bq. ■the stopActiveServices() call maybe not necessary ? as the AbstractService 
class internally should call stop if any exception occurs

bq. ■fix following code comment 

bq. ■maybe we can invoke following right before each time start the active 
Invoking before startActiveServices causes reinitialization of active services 
every time trainstionToActive which is not needed in positive flow.  I thought 
of removing completely activeservice initializition for trainsitionToStandby, 
but it has potential dependency on starting RMWebApp. I do not know why 
RMWebbApp has dependency on activeServices for starting in standby mode.Is it a 

> Standby RM does not transitionToActive if previous transitionToActive is 
> failed with ZK exception.
> --------------------------------------------------------------------------------------------------
>                 Key: YARN-2588
>                 URL: https://issues.apache.org/jira/browse/YARN-2588
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0, 2.6.0, 2.5.1
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: YARN-2588.patch
> Consider scenario where, StandBy RM is failed to transition to Active because 
> of ZK exception(connectionLoss or SessionExpired). Then any further 
> transition to Active for same RM does not move RM to Active state.

This message was sent by Atlassian JIRA

Reply via email to